Has the engine had any other mods? Usually you don't need vac advance, but, you need to advance static timing slightly about 2 or 3 degrees and restrict the total advance about same amount, using piece of hard tube over stop in dissy. Other than that points are fine, the electronic dissy conversion listed on forum is a good conversion, can't find link at moment thou.
Bookmarks